andygrove opened a new pull request, #3024:
URL: https://github.com/apache/datafusion-comet/pull/3024
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Improvements Made
1. Improved Test Data (prepareTestTable)
- c1: Random long values (full range) - original data
- c2: Values 0-99 (ABS(value % 100)) - ensures even distribution across
branches for multi-branch tests
- c3: Secondary long column (value * 2) - for non-literal result expressions
- c4: String column - for potential string result tests
2. New Benchmark Cases (8 total, up from 2)
| Benchmark | Description
|
|-------------------------------------------|-------------------------------------------------------|
| caseWhenLiteralBenchmark | 3-branch CASE WHEN with string
literal results |
| caseWhenManyBranchesLiteralBenchmark | 10-branch CASE WHEN with
string literal results |
| caseWhenColumnResultBenchmark | 3-branch CASE WHEN with
column/expression results |
| caseWhenManyBranchesColumnResultBenchmark | 10-branch CASE WHEN with
column/expression results |
| ifLiteralBenchmark | Simple IF with string literal
results |
| ifColumnResultBenchmark | Simple IF with
column/expression results |
| nestedIfBenchmark | Nested IF (4 outcomes) with
string literals |
| nestedIfColumnResultBenchmark | Nested IF (4 outcomes) with
column/expression results |
3. Key Test Dimensions
- Branch count: 3 vs 10 branches (tests scalability)
- Result type: Literals vs column expressions (tests materialization
overhead)
- Expression style: CASE WHEN vs IF vs nested IF
The benchmark now provides much better coverage of real-world conditional
expression patterns.
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
