2010YOUY01 commented on PR #19609: URL: https://github.com/apache/datafusion/pull/19609#issuecomment-3706665874
Thank you for the review, those feedbacks make sense to me, I'll batch them later > Some initial comments. Need to read a couple more times to actually wrap my had around how it's working. unclear. I’m trying to make both the implementation and the documentation clearer, but the logic and edge cases for this feature are admittedly quite tricky. > Is the plan to make multiple subsequent PRs to add more handling e.g. for `Like` expressions, UDFs, etc. and then eventually once we reach feature parity replace the current system? Yes — the initial milestone should be reaching coverage equivalent to the existing `PruningPredicate` implementation, so we can reuse the existing tests and gain more confidence. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
