theirix commented on code in PR #19311: URL: https://github.com/apache/datafusion/pull/19311#discussion_r2658821153
########## datafusion/sql/src/lib.rs: ########## @@ -48,7 +48,7 @@ mod expr; pub mod parser; pub mod planner; mod query; -mod relation; +pub mod relation; Review Comment: I think a newly introduced `SqlToRelRelationContext` being public could help extend datafusion. I faced a problem with writing unit tests (not required in this PR, but could be helpful) without a public context. Otherwise, I can easily revert; there is no need in this particular PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
