Kimahriman commented on code in PR #3035:
URL: https://github.com/apache/datafusion-comet/pull/3035#discussion_r2659688631
##########
native/core/Cargo.toml:
##########
@@ -76,7 +76,7 @@ parking_lot = "0.12.5"
datafusion-comet-objectstore-hdfs = { path = "../hdfs", optional = true,
default-features = false, features = ["hdfs"] }
reqwest = { version = "0.12", default-features = false, features =
["rustls-tls-native-roots", "http2"] }
object_store_opendal = {version = "0.55.0", optional = true}
-hdfs-sys = {version = "0.3", optional = true, features = ["hdfs_3_3"]}
+hdfs-sys = {version = "0.3", optional = true, features = ["hdfs_3_3",
"vendored"]}
Review Comment:
With opendal enabled by default in
https://github.com/apache/datafusion-comet/pull/2929, I was getting failures
finding libhdfs.so running unit tests on Linux. The `hdrs` dependency below for
macos was purely activating the `vendored` feature of hdfs-sys, so I just
enabled that globally here so you don't need `libhdfs` available for developing
on Linux either
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
