viirya commented on code in PR #19635: URL: https://github.com/apache/datafusion/pull/19635#discussion_r2659844657
########## datafusion/sqllogictest/test_files/joins.slt: ########## @@ -3516,7 +3516,6 @@ AS VALUES query IT SELECT t1_id, t1_name FROM join_test_left WHERE t1_id NOT IN (SELECT t2_id FROM join_test_right) ORDER BY t1_id; ---- -NULL e Review Comment: The test was expecting (NULL, 'e') to be returned by a NOT IN query when the subquery contains NULL values. This is incorrect according to SQL semantics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
