ntjohnson1 commented on PR #19549: URL: https://github.com/apache/datafusion/pull/19549#issuecomment-3710556356
> now we are changing/improving the behavior of `drop_columns`, we should probably update the documentation (wherever the right place is?). I mean after this PR `drop_columns` now uses `find_qualified_columns` so now: > > * Qualified names are supported > * Missing columns now error instead of silently failing So the `drop_columns` documentation actually doesn't specify anything about qualified or unqualified names at the moment https://github.com/apache/datafusion/blob/3cd4e67f7e0650e25bd4096ecb49355ddbba68b5/datafusion/core/src/dataframe/mod.rs#L419 which was my original issue. IMO this makes the implementation match the existing documentation. Also just clarification that `drop_columns` doesn't actually call find_qualified_columns. Instead `find_qualified_columns` is a public helper that makes it easier to call `drop_columns` with qualified names if you don't remember the table name for a dataframe but have the variable for that dataframe lying around (I added a test for this use case). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
