mattcuento commented on code in PR #1360:
URL:
https://github.com/apache/datafusion-ballista/pull/1360#discussion_r2661949450
##########
ballista/scheduler/Cargo.toml:
##########
@@ -52,6 +53,7 @@ clap = { workspace = true, optional = true }
dashmap = { workspace = true }
datafusion = { workspace = true }
datafusion-proto = { workspace = true }
+datafusion-substrait = { workspace = true, optional = true }
Review Comment:
Yeah fairly odd... I've noticed that alternatively, ballista core is able to
pass a flag that makes the compilation work without a newer `protoc` version
`--experimental_allow_proto3_optional`. However, for us here this is in the
compilation of the proto files within the `substrait dependency
(`algebra.proto`?) as opposed to source code.
I'm not sure if there's an equivalent way to pass that flag down.
```
tonic_prost_build::configure()
.extern_path(".datafusion_common", "::datafusion_proto_common")
.extern_path(".datafusion", "::datafusion_proto::protobuf")
.protoc_arg("--experimental_allow_proto3_optional")
.compile_protos(&["proto/ballista.proto"], &["proto"])
.map_err(|e| format!("protobuf compilation failed: {e}"))?;
```
I'll keep messing around here for a bit to see what I can do!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
