alamb commented on code in PR #19622:
URL: https://github.com/apache/datafusion/pull/19622#discussion_r2662653579
##########
datafusion/physical-plan/src/coalesce_batches.rs:
##########
@@ -57,6 +57,10 @@ use futures::stream::{Stream, StreamExt};
/// reaches the `fetch` value.
///
/// See [`LimitedBatchCoalescer`] for more information
+#[deprecated(
+ since = "52.0.0",
+ note = "We now use BatchCoalescer from arrow-rs instead of a dedicated
operator"
Review Comment:
👍
##########
datafusion/core/tests/physical_optimizer/filter_pushdown/mod.rs:
##########
@@ -921,61 +917,6 @@ async fn
test_topk_filter_passes_through_coalesce_partitions() {
);
}
-#[tokio::test]
-async fn test_topk_filter_passes_through_coalesce_batches() {
Review Comment:
I think being able to remove this type of test is a great example of why
this change is so nice -- it makes everything simpler and there are fewer code
paths to check
##########
datafusion/core/tests/physical_optimizer/replace_with_order_preserving_variants.rs:
##########
@@ -440,9 +439,7 @@ async fn
test_replace_multiple_input_repartition_with_extra_steps(
let repartition_rr = repartition_exec_round_robin(source);
let repartition_hash = repartition_exec_hash(repartition_rr);
Review Comment:
not for this PR, but I think now actually we have fixed the double
repartition as well, as described in
https://datafusion.apache.org/blog/output/2025/12/15/avoid-consecutive-repartitions/
@gene-bordegaray is that correct? if so I will file a ticket to try and
update these tests so they match what datafusion creates now (a single round
robin hash)
##########
datafusion/core/tests/physical_optimizer/pushdown_sort.rs:
##########
@@ -870,7 +832,7 @@ fn test_sort_pushdown_projection_with_limit() {
}
#[test]
-fn test_sort_pushdown_through_projection_and_coalesce() {
+fn test_sort_pushdown_through_projection() {
Review Comment:
thank you for updating all these tests -- I think they now better reflect
what plans are created
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
