gokselk opened a new pull request, #19663: URL: https://github.com/apache/datafusion/pull/19663
## Which issue does this PR close? Closes #19117. ## Rationale for this change The `to_timestamp` function family lacks consistency in supported argument types. While `to_timestamp` accepts Float64 and Decimal128 types, the related functions (`to_timestamp_seconds`, `to_timestamp_millis`, `to_timestamp_micros`, `to_timestamp_nanos`) don't offer the same support. Additionally, the documentation claims support for "unsigned integer" types, but this isn't fully implemented. ## What changes are included in this PR? Standardizes all `to_timestamp` variants to uniformly support: - All signed integer types: Int8, Int16, Int32, Int64 - All unsigned integer types: UInt8, UInt16, UInt32, UInt64 - Float32 and Float64 - Decimal128 (for millis/micros/nanos variants) ## Are these changes tested? Yes, added comprehensive SQL logic tests in `datafusion/sqllogictest/test_files/datetime/timestamps.slt`. ## Are there any user-facing changes? Users can now pass additional numeric types to `to_timestamp` functions. This is a backward-compatible enhancement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
