milenkovicm opened a new issue, #19664: URL: https://github.com/apache/datafusion/issues/19664
as part of #18880 `BatchPartitioner` `try_new` method got two additional parameters, which are only relevant for `round_robin` partitioning ```diff - let mut partitioner = - BatchPartitioner::try_new(partitioning, metrics.repartition_time.clone())?; + let mut partitioner = BatchPartitioner::try_new( + partitioning, + metrics.repartition_time.clone(), + input_partition, + num_input_partitions, + )?; ``` As those two new parameters are only relevant for round robin, it would make sense splitting the method. > Sorry I'm a bit late with my comment. I've stumbled upon this change updating ballista. Its a bit confusing change from usage perspective, there are two parameters which are used only in round robin case, would it make sense splitting `try_new` method in `try_new_hash` and `try_new_round_robin`? _Originally posted by @milenkovicm in https://github.com/apache/datafusion/issues/18880#issuecomment-3705240337_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
