avantgardnerio commented on code in PR #19642:
URL: https://github.com/apache/datafusion/pull/19642#discussion_r2664918318
##########
datafusion/expr/src/udwf.rs:
##########
@@ -427,21 +440,130 @@ pub trait WindowUDFImpl: Debug + DynEq + DynHash + Send
+ Sync {
None
}
- /// If not causal, returns the effect this function will have on the window
+ /// Returns the effect this function has on limit pushdowns. See
[`LimitEffect`]
+ /// for more details.
+ ///
+ /// Defaults to [`LimitEffect::Unknown`].
fn limit_effect(&self, _args: &[Arc<dyn PhysicalExpr>]) -> LimitEffect {
LimitEffect::Unknown
}
}
-/// the effect this function will have on the limit pushdown
+/// The effect this function will have on limit pushdowns through a window
bound.
Review Comment:
Perhaps we are over thinking it:
```suggestion
/// the effect this function will have on the limit pushdown (e.g. through a
window bound)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
