adriangb commented on PR #19659: URL: https://github.com/apache/datafusion/pull/19659#issuecomment-3715147894
Sound good to me. Could we look for any potential call sites and update them to use `snapshot_physical_expr` *if* they care about differentiating between two `DynamicFilterPhysicalExpr`? E.g. in #19639 I needed to differentiate them because if a `DynamicFilterPhysicalExpr` updates it's expression I want to treat it differently than the previous version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
