andygrove commented on code in PR #3045:
URL: https://github.com/apache/datafusion-comet/pull/3045#discussion_r2665656660
##########
spark/src/test/scala/org/apache/spark/sql/benchmark/CometBenchmarkBase.scala:
##########
@@ -158,6 +163,28 @@ trait CometBenchmarkBase extends SqlBasedBenchmark {
benchmark.run()
}
+ /**
+ * Finds the first non-Comet operator in the plan, if any. This is used to
verify that
+ * benchmarks are running fully on Comet native when expected.
+ *
+ * Based on CometTestBase.findFirstNonCometOperator.
+ */
+ protected def findFirstNonCometOperator(plan: SparkPlan): Option[SparkPlan]
= {
Review Comment:
I moved this to a new `CometPlanChecker` trait to avoid duplication.
We may want to rename this trait in the future if we move more code there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
