andygrove commented on PR #3017:
URL:
https://github.com/apache/datafusion-comet/pull/3017#issuecomment-3715626677
These are nice speedups. Thanks @coderfender. I will review again later
today.
```
$ cargo bench --bench cast_from_string -- --baseline main
Finished `bench` profile [optimized + debuginfo] target(s) in 0.17s
Running benches/cast_from_string.rs
(target/release/deps/cast_from_string-9c9caa2565779a11)
Gnuplot not found, using plotters backend
cast_string_to_int/cast_string_to_i8
time: [10.269 µs 10.308 µs 10.356 µs]
change: [−44.807% −44.528% −44.214%] (p = 0.00 <
0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe
cast_string_to_int/cast_string_to_i16
time: [10.260 µs 10.295 µs 10.335 µs]
change: [−44.683% −44.444% −44.202%] (p = 0.00 <
0.05)
Performance has improved.
Found 13 outliers among 100 measurements (13.00%)
9 (9.00%) high mild
4 (4.00%) high severe
cast_string_to_int/cast_string_to_i32
time: [10.348 µs 10.380 µs 10.417 µs]
change: [−43.119% −42.940% −42.761%] (p = 0.00 <
0.05)
Performance has improved.
Found 14 outliers among 100 measurements (14.00%)
11 (11.00%) high mild
3 (3.00%) high severe
cast_string_to_int/cast_string_to_i64
time: [14.733 µs 14.773 µs 14.824 µs]
change: [−39.389% −38.514% −37.613%] (p = 0.00 <
0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
4 (4.00%) high mild
2 (2.00%) high severe
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
