adriangb opened a new pull request, #3047: URL: https://github.com/apache/datafusion-comet/pull/3047
## Summary This PR prepares for DataFusion 52.0 by migrating from the deprecated `SchemaAdapter` approach to the new `PhysicalExprAdapter` approach. **Key changes:** - Add `SparkPhysicalExprAdapterFactory` and `SparkPhysicalExprAdapter` that work at planning time (expression rewriting) instead of runtime (batch transformation) - Replace `CastColumnExpr` with Spark-compatible `Cast` expressions - Update `parquet_exec.rs` to use `with_expr_adapter()` instead of `with_schema_adapter_factory()` - Update Iceberg scan to use `adapt_batch_with_expressions()` - Mark old `SparkSchemaAdapterFactory` as deprecated **The new approach:** 1. `PhysicalExprAdapterFactory.create()` returns `PhysicalExprAdapter` 2. `PhysicalExprAdapter.rewrite()` transforms expressions at planning time 3. Casts are injected as expressions that execute when the plan runs See [DataFusion upgrading guide](https://github.com/apache/datafusion/blob/main/docs/source/library-user-guide/upgrading.md) for more context on this migration. ## Test plan - [ ] Verify build compiles successfully - [ ] Run existing schema adapter tests - [ ] Test Parquet roundtrip with type casting - [ ] Test Iceberg scan with schema evolution 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
