mohit7705 commented on code in PR #19668:
URL: https://github.com/apache/datafusion/pull/19668#discussion_r2665970890
##########
datafusion/physical-plan/src/repartition/mod.rs:
##########
@@ -437,30 +437,58 @@ impl BatchPartitioner {
/// Create a new [`BatchPartitioner`] with the provided [`Partitioning`]
///
/// The time spent repartitioning will be recorded to `timer`
+ /// Create a new [`BatchPartitioner`] for hash partitioning
+ pub fn try_new_hash(
Review Comment:
Thanks for the review! 🙏
I’ve addressed the comments by:
- Renaming the constructors to remove `try_` and `Result` where they cannot
fail
- Updating all call sites accordingly
- Adding detailed documentation explaining each parameter and behavior
Please let me know if anything else needs adjustment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
