Jefffrey commented on issue #19250: URL: https://github.com/apache/datafusion/issues/19250#issuecomment-3716744458
> I think there are still some checks to fix from a cursory glance at the code: > > [datafusion/datafusion/functions/src/utils.rs](https://github.com/apache/datafusion/blob/f1e5c94f3ab3722c15984408ae34cae82a216665/datafusion/functions/src/utils.rs#L202-L206) > > Lines 202 to 206 in [f1e5c94](/apache/datafusion/commit/f1e5c94f3ab3722c15984408ae34cae82a216665) > if scale < 0 { > Err(ArrowError::ComputeError( > "Negative scale is not supported".into(), > )) > } else if scale == 0 { > > [datafusion/datafusion/functions/src/utils.rs](https://github.com/apache/datafusion/blob/f1e5c94f3ab3722c15984408ae34cae82a216665/datafusion/functions/src/utils.rs#L219-L223) > > Lines 219 to 223 in [f1e5c94](/apache/datafusion/commit/f1e5c94f3ab3722c15984408ae34cae82a216665) > if scale < 0 { > Err(ArrowError::ComputeError( > "Negative scale is not supported".into(), > )) > } else if scale == 0 { > > [datafusion/datafusion/functions/src/utils.rs](https://github.com/apache/datafusion/blob/f1e5c94f3ab3722c15984408ae34cae82a216665/datafusion/functions/src/utils.rs#L236-L240) > > Lines 236 to 240 in [f1e5c94](/apache/datafusion/commit/f1e5c94f3ab3722c15984408ae34cae82a216665) > if scale < 0 { > Err(ArrowError::ComputeError( > "Negative scale is not supported".into(), > )) > } else if scale == 0 { Update: this is fine, callers guard against passing in negative scale so this is intended -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
