Jefffrey commented on code in PR #19372: URL: https://github.com/apache/datafusion/pull/19372#discussion_r2667260391
########## datafusion/sqllogictest/test_files/decimal.slt: ########## @@ -896,14 +898,20 @@ select log(2, 100000000000000000000000000000000000::decimal(38,0)); ---- 116 -# log(10^35) for decimal128 with another base +# log(10^35) for decimal128 with another base (float base) # TODO: this should be 116.267483321058, error with native decimal log impl # https://github.com/apache/datafusion/issues/18524 query R select log(2.0, 100000000000000000000000000000000000::decimal(38,0)); ---- 116 +# log with non-integer base now works (fallback to f64) Review Comment: ```suggestion # log with non-integer base (fallback to f64) ``` ########## datafusion/sqllogictest/test_files/decimal.slt: ########## @@ -896,14 +898,20 @@ select log(2, 100000000000000000000000000000000000::decimal(38,0)); ---- 116 -# log(10^35) for decimal128 with another base +# log(10^35) for decimal128 with another base (float base) Review Comment: ```suggestion # log(10^35) for decimal128 with another base ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
