haohuaijin commented on code in PR #19285:
URL: https://github.com/apache/datafusion/pull/19285#discussion_r2668719929
##########
datafusion/core/benches/topk_aggregate.rs:
##########
@@ -170,6 +204,55 @@ fn criterion_benchmark(c: &mut Criterion) {
.as_str(),
|b| b.iter(|| run(&rt, ctx.clone(), limit, true, true)),
);
+
+ // String aggregate benchmarks - grouping by timestamp, aggregating string
column
+ let ctx = rt
Review Comment:
one suggestion, added benchmark always use topk, we should add some
benchmark do not use topk, then we can compare, like below
```rust
let ctx = rt
.block_on(create_context(partitions, samples, false, false, false))
.unwrap();
c.bench_function(
format!(
"string aggregate {} time-series rows [Utf8]",
partitions * samples
)
.as_str(),
|b| b.iter(|| run_string(&rt, ctx.clone(), limit, false)),
);
let ctx = rt
.block_on(create_context(partitions, samples, true, false, false))
.unwrap();
c.bench_function(
format!(
"string aggregate {} worst-case rows [Utf8]",
partitions * samples
)
.as_str(),
|b| b.iter(|| run_string(&rt, ctx.clone(), limit, false)),
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
