yoavcloud commented on code in PR #2152:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2152#discussion_r2668799525
##########
src/parser/mod.rs:
##########
@@ -3485,10 +3485,10 @@ impl<'a> Parser<'a> {
Token::DuckIntDiv if dialect_is!(dialect is DuckDbDialect |
GenericDialect) => {
Some(BinaryOperator::DuckIntegerDivide)
}
- Token::ShiftLeft if dialect_is!(dialect is PostgreSqlDialect |
DuckDbDialect | GenericDialect | RedshiftSqlDialect) => {
+ Token::ShiftLeft if dialect_is!(dialect is PostgreSqlDialect |
DuckDbDialect | GenericDialect | RedshiftSqlDialect | MySqlDialect) => {
Review Comment:
I would add a dialect function such as `supports_shift_left_operator` to
adhere to the new coding standard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
