andygrove commented on code in PR #2905:
URL: https://github.com/apache/datafusion-comet/pull/2905#discussion_r2669068808
##########
spark/src/test/scala/org/apache/comet/CometMapExpressionSuite.scala:
##########
@@ -157,4 +159,61 @@ class CometMapExpressionSuite extends CometTestBase {
}
}
+ test("map_from_entries") {
+ withTempDir { dir =>
+ val path = new Path(dir.toURI.toString, "test.parquet")
+ val filename = path.toString
+ val random = new Random(42)
+ withSQLConf(CometConf.COMET_ENABLED.key -> "false") {
+ val schemaGenOptions =
+ SchemaGenOptions(
+ generateArray = false,
+ generateStruct = false,
+ primitiveTypes =
SchemaGenOptions.defaultPrimitiveTypes.filterNot(_ == BinaryType))
+ val dataGenOptions = DataGenOptions(allowNull = false,
generateNegativeZero = false)
+ ParquetGenerator.makeParquetFile(
+ random,
+ spark,
+ filename,
+ 100,
+ schemaGenOptions,
+ dataGenOptions)
+ }
+ withSQLConf(
+ CometConf.COMET_NATIVE_SCAN_ENABLED.key -> "false",
Review Comment:
@kazantsev-maksim Could you also add a test where native scan is enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
