comphead commented on code in PR #3036:
URL: https://github.com/apache/datafusion-comet/pull/3036#discussion_r2669818064
##########
spark/src/test/scala/org/apache/comet/CometArrayExpressionSuite.scala:
##########
@@ -871,4 +872,20 @@ class CometArrayExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelp
}
}
}
+
+ test("size - respect to legacySizeOfNull") {
+ val table = "t1"
+ withSQLConf(CometConf.COMET_NATIVE_SCAN_IMPL.key ->
CometConf.SCAN_NATIVE_ICEBERG_COMPAT) {
Review Comment:
we need to make sure the ansi mode is off here. According to Spark
```
This function returns -1 for null input only if spark.sql.ansi.enabled is
false and spark.sql.legacy.sizeOfNull is true. Otherwise, it returns null for
null input. With the default settings, the function returns null for null input.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
