alamb commented on code in PR #19619: URL: https://github.com/apache/datafusion/pull/19619#discussion_r2670098891
########## docs/source/library-user-guide/upgrading.md: ########## @@ -25,6 +25,42 @@ You can see the current [status of the `52.0.0`release here](https://github.com/apache/datafusion/issues/18566) +### `FilterExec` builder methods deprecated Review Comment: We need to move these to the 53 release section ########## datafusion/physical-plan/src/filter.rs: ########## @@ -140,6 +209,13 @@ impl FilterExec { } /// Return new instance of [FilterExec] with the given projection. + /// + /// # Deprecated + /// Use [`FilterExecBuilder::with_projection`] instead + #[deprecated( + since = "52.0.0", Review Comment: this technically will now go out in 53 I think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
