Standing-Man commented on code in PR #19672:
URL: https://github.com/apache/datafusion/pull/19672#discussion_r2670820089
##########
datafusion/expr/src/expr.rs:
##########
@@ -1403,7 +1403,9 @@ pub struct PlannedReplaceSelectItem {
impl Display for PlannedReplaceSelectItem {
fn fmt(&self, f: &mut Formatter) -> fmt::Result {
write!(f, "REPLACE")?;
- write!(f, " ({})", display_comma_separated(&self.items))?;
+ for item in &self.items {
+ write!(f, " ({item})")?;
+ }
Review Comment:
If you take a second look, you’ll see that the display_comma_separated
method is a private helper used to format `ReplaceSelectItem`. 😄
https://github.com/apache/datafusion-sqlparser-rs/blob/main/src/ast/query.rs#L960-L966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
