jonahgao commented on code in PR #19519:
URL: https://github.com/apache/datafusion/pull/19519#discussion_r2672532009
##########
datafusion/sql/src/resolve.rs:
##########
@@ -193,19 +213,20 @@ pub fn resolve_table_references(
relations: BTreeSet::new(),
all_ctes: BTreeSet::new(),
ctes_in_scope: vec![],
+ normalizer: IdentNormalizer::new(enable_ident_normalization),
};
visit_statement(statement, &mut visitor);
let table_refs = visitor
.relations
.into_iter()
- .map(|x| object_name_to_table_reference(x, enable_ident_normalization))
+ .map(|x| object_name_to_table_reference(x, false))
Review Comment:
Can `RelationVisitor` directly collect normalized table references instead
of raw object names so that there is no need for a second normalization here?
##########
datafusion/sql/src/resolve.rs:
##########
@@ -193,19 +213,20 @@ pub fn resolve_table_references(
relations: BTreeSet::new(),
all_ctes: BTreeSet::new(),
ctes_in_scope: vec![],
+ normalizer: IdentNormalizer::new(enable_ident_normalization),
};
visit_statement(statement, &mut visitor);
let table_refs = visitor
.relations
.into_iter()
- .map(|x| object_name_to_table_reference(x, enable_ident_normalization))
+ .map(|x| object_name_to_table_reference(x, false))
Review Comment:
Can `RelationVisitor` directly collect normalized table references instead
of object names so that there is no need for a second normalization here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
