crepererum commented on code in PR #18412: URL: https://github.com/apache/datafusion/pull/18412#discussion_r2676602381
########## datafusion/sqllogictest/test_files/metadata.slt: ########## @@ -235,7 +251,28 @@ order by 1 asc nulls last; 3 1 NULL 1 -# Regression test: first_value should preserve metadata Review Comment: shouldn't this comment stay? I think it describes the query below (that used to start at line 239 and is now on line 276) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
