alamb commented on code in PR #19731:
URL: https://github.com/apache/datafusion/pull/19731#discussion_r2683084126
##########
datafusion/sqllogictest/test_files/join.slt.part:
##########
@@ -973,19 +973,19 @@ ON e.emp_id = d.emp_id
WHERE ((dept_name != 'Engineering' AND e.name = 'Alice') OR (name != 'Alice'
AND e.name = 'Carol'));
----
logical_plan
-01)Filter: d.dept_name != Utf8View("Engineering") AND e.name =
Utf8View("Alice") OR e.name != Utf8View("Alice") AND e.name = Utf8View("Carol")
Review Comment:
Update -- looking at this, it seems like actually the predicate actually
did resolve both `name` references to the same thing (`name@1`) in the physical
plan
> 01)FilterExec: dept_name@2 != Engineering AND name@1 = Alice OR name@1 !=
Alice AND name@1 = Carol
Maybe we can update this test (in a follow on PR) so it uses the fully
qualified column references to make it clearer the intent
```sql
((d.dept_name != 'Engineering' AND e.name = 'Alice') OR (e.name != 'Alice'
AND e.name = 'Carol'));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
