iffyio commented on code in PR #2160:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2160#discussion_r2686009306
##########
src/parser/mod.rs:
##########
@@ -5455,14 +5460,14 @@ impl<'a> Parser<'a> {
&mut self,
or_replace: bool,
temporary: bool,
- ) -> Result<Statement, ParserError> {
+ ) -> Result<CreateFunction, ParserError> {
Review Comment:
Not sure I followed the intent of this diff - we're changing the public APIs
to return not an actual statement anymore but its not clear to me why that's a
desirable change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
