gabotechs commented on code in PR #19759:
URL: https://github.com/apache/datafusion/pull/19759#discussion_r2726767044
##########
datafusion/execution/src/memory_pool/mod.rs:
##########
@@ -367,8 +367,8 @@ impl MemoryReservation {
/// Frees all bytes from this reservation back to the underlying
/// pool, returning the number of bytes freed.
- pub fn free(&mut self) -> usize {
- let size = self.size;
+ pub fn free(&self) -> usize {
+ let size = self.size.load(atomic::Ordering::Relaxed);
Review Comment:
Running some benchmarks just in case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
