xudong963 commented on code in PR #19918:
URL: https://github.com/apache/datafusion/pull/19918#discussion_r2730802413
##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -457,9 +457,9 @@ fn push_down_all_join(
// For infer predicates, if they can not push through join, just drop them
for predicate in inferred_join_predicates {
- if left_preserved && checker.is_left_only(&predicate) {
+ if checker.is_left_only(&predicate) {
left_push.push(predicate);
- } else if right_preserved && checker.is_right_only(&predicate) {
+ } else if checker.is_right_only(&predicate) {
right_push.push(predicate);
}
Review Comment:
yeah. `infer_join_predicates_from_on_filters` should do the similiar check,
so predicates in `inferred_join_predicates` should be pushed down safely
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
