adriangb commented on code in PR #19928:
URL: https://github.com/apache/datafusion/pull/19928#discussion_r2731532157
##########
datafusion/pruning/src/pruning_predicate.rs:
##########
@@ -461,7 +473,11 @@ impl PruningPredicate {
/// returns a new expression.
/// It is recommended that you pass the expressions through
[`PhysicalExprSimplifier`]
/// before calling this method to make sure the expressions can be used
for pruning.
- pub fn try_new(mut expr: Arc<dyn PhysicalExpr>, schema: SchemaRef) ->
Result<Self> {
+ pub fn try_new(
Review Comment:
This is a good call out, I agree with this. The only issue is that `try_new`
does all of the work / compute. So we probably need something like
`PruningPredicateBuilder` and an internal `try_new_with_config` that `try_new`
delegates to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
