adriangb commented on PR #20037: URL: https://github.com/apache/datafusion/pull/20037#issuecomment-3807464659
@milenkovicm I'm curious what you think of this now with the simpler implementation thanks to Tim's refactor? I think your concern about re-use and pointer collision still exists. I added some comments to try to address this. If you think it's still a concern we could add an optional method on the trait called `reset_state()` or something that top level functions call automatically? Or we could make them accept an owned value instead of a reference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
