> The fact that there is already a serious try for this enhancement makes me a 
> little bit confident

Testing and to discover how to overcome the multiple signals for the same event 
is mostly what's needed before it can be enabled by default, I think.

If I remember correctly, the main problem was that when saving a file, it would 
trigger a modification event from that very save, causing the infobar message 
to pop back up after saving. You can't just disable monitoring, save, and then 
re-enable monitoring, as the actual event comes back from the kernel "some 
time" later, which, if memory serves, was often/always after re-enabling 
monitoring. If Geany waits too long to re-enable monitoring, it could miss 
events, so basically we'd need the alternate methods of checking (timer, 
tab-switch) still, and in such a case, the monitoring events won't come right 
away, thus defeating the purpose of file monitoring, to some extent.

We should look at other apps that use inotify/GFileMonitor to see how they 
handle it, maybe there's a trick that the current code isn't using to avoid 
this situation.

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/847#issuecomment-169185283

Reply via email to