> +{
> +     TMParserMap *map = &parser_map[lang];
> +     guint i;
> +
> +     for (i = 0; i < map->size; i++)
> +     {
> +             TMParserMapEntry *entry = &map->entries[i];
> +
> +             if (entry->type == type)
> +                     return entry->kind;
> +     }
> +     return '-';
> +}
> +
> +
> +void tm_parser_verify_type_mappings(void)

Yes, I agree with the g_error() stuff - I was referring to the patch you are 
working on and whether it's necessary (I guess you want to have some 
command-line flag to enable-disable the test, right?). Without any such patch 
the check will be done every time geany starts so totally about 300 times when 
run for every test - still the total time spent on the checks will be less than 
1ms on my machine and similarly marginal compared to the total time spent on 
the tests for every other platform. So the question is whether such a patch is 
worth the work.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/957/files/aea7d7845917843dd6b02e5a8dc9031cabc87a86..5d9376ea801a6e6c3ec22748741362a3a2eff7ac#r62079223

Reply via email to