>       geany_object_signals[GCB_DOCUMENT_FILETYPE_SET] = g_signal_new (
>               "document-filetype-set",
>               G_OBJECT_CLASS_TYPE (g_object_class),
>               G_SIGNAL_RUN_FIRST,
> -             G_STRUCT_OFFSET (GeanyObjectClass, document_filetype_set),
> -             NULL, NULL,
> -             geany_cclosure_marshal_VOID__POINTER_POINTER,
> +             0, NULL, NULL, g_cclosure_marshal_generic,

shouldn't you simply pass `NULL` as the marshaller instead of explicitly 
passing the generic one?  Clearer for me (as I'm not fooled to see there's a 
specific one selected), shorter, and there doesn't seem to be no use for 
passing it explicitly, is it? 

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1038/files/c9f291ae4015a3bb8d6ea142b1beb6c9fcc43129#r64231049

Reply via email to