> whitespace formatting (converting tabs-and-spaces indentation to tabs-only > indentation) - I could of course make this e.g. one commit per file but what > would be the point of this?
There is no technical point, but there is a social point. The point would be to allow the changes to be easier for committers to review in small digestable chunks, without having to split the changeset themselves, they are doing it in their own time, don't try to take up their free time in a big chunk. The whitespace commits are exactly the sort of thing that can be done in independent chunks. If its a small chunk with only whitespace changes I can look at it and help @b4n, but if its a big lump I'm not going to take that much time out of the other things I'm doing. > reorganization that happened in ctags which removed stuff from ctags.c and > moved it to various other files (it's impossible to split this one into > multiple commits because once you start moving the code, you have to move all) Thats fine, but that should be separate from whitespace changes. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1160#issuecomment-237409673
