> Changing anything that returns memory back to Geany from g_* to malloc means > the frees inside Geany need to be changed from g_free() tofree() since you > can't mix them (according to the Glib description section) It is going to be > confusing if some memory in geany needs to be g_freed and some plain freed. > And I hope none of that gets to the plugin API.
There are no frees of ctags values inside Geany - we copy the values from ctags tag entries and let ctags handle the memory management of its values. This shouldn't be a problem. > g_strerror() is different to POSIX in that its guaranteed UTF-8 whereas POSIX > is locale dependent. That means it needs conversion if its to be displayed in > the UI. OT not all g_ string changes were part of a global change 😁 This is in an error reporting function and from what I could see the new uctags code allows registering custom reporting function which we should do. So this shouldn't be a problem either. > I believe g_stat etc work around much windows weirdness, which would have to > be solved if the Glib version was not used. (BTW why don't these get #605 > type problems?) Those are coming from the dead code (for Geany) anyway so it doesn't matter much. And ctags supports Windows natively so I suppose they solve various platform-specific quirks anyway. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1160#issuecomment-237534564
