> @elextr @techee see, 6bc5797 was quicker to review than some previous patches 
> 'cause git show -b 6bc579798716dbe94a171a016f9989c92c4b67e2 was very 
> straightforward :) (about 62 lines changes (vim settings), instead of about 
> 7446)

I could have smuggled in some evil indents which you don't see this way :-P. In 
fact there are some indent diffs compared to uctags - Geany always replaces 
tabs with spaces but it replaces spaces with tabs only at the beginning of a 
line:

https://github.com/geany/geany/blob/master/src/editor.c#L4484 (based on the 
comment in the corresponding commit it's probably OK).

This means that e.g. between

```
some_code();       /* some comment */
```

the whitespace used is incorrect. But the number of these is much smaller and 
these can get fixed on the way.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1160#issuecomment-237558212

Reply via email to