A good example of why is the changes to `ui_menu_add_document_items_sorted()`: the *format* should contain markup, but the placeholders should not (they will generally be mostly unknown text).
This however has one side effect on the API: [`ui_frame_new_with_alignment()`](https://www.geany.org/manual/reference/ui__utils_8h.html#a740aa567ff6b9e3829565193e8317706)'s first argument is passed as-is to `ui_label_new_bold()`, which itself is implemented using `ui_label_set_markup()`. The documentation of `ui_frame_new_with_alignment()` never suggested it supported markup (and none of the users I could fine did expect that), but it's a change in how the API works. IMO it's a bug fix (markup control character no longer break frame labels), but someone could see it as a feature removal (although it'd be somewhat dishonest as it never was advertized). You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/1174 -- Commit Summary -- * Escape format arguments passed to ui_label_set_markup() -- File Changes -- M src/ui_utils.c (10) -- Patch Links -- https://github.com/geany/geany/pull/1174.patch https://github.com/geany/geany/pull/1174.diff --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1174
