I have not reviewed the internal semantic change yet and don't much care, as long as it still lets me give my files a new name (and never leaves me without old or new file on disk on error), but I don't like the change to 'Save and Remove Original' for a number of reasons: 1) it obfuscates what the feature does, 'Rename' is perfectly fine no matter the exact implementation details and 'Save and Remove Original' is just a really weird and confusing way to say 'Rename', 2) it causes needless translation churn and may even be hard to translate in some languages, 3) it could cause the dialog button to be even longer than the already too long 'Save and Remove Original' in some languages.
-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1190#issuecomment-241937979
