> My filemanager names copies you paste in the same directory as 
> "filename(copy).ext" "filename(another copy).ext" "filename(3rd copy).ext" 
> and there I got too bored to see what it did at 10 :) 

It's all about making cloning of documents easier and faster.

> I'm not sure this is really enough of a problem to need code added for it, do 
> a lot of users clone files all the time?

I do.  Most of the time, when creating versions, or using a document as a 
template for another, and also when creating temporary copies; one of the 
reasons is to differentiate versions among branches in git, or just use as 
reference for copying code; another is simply for immediate backup.

This is pretty much very helpful to developers, especially if combined with 
in-place renaming.

> 1) it is touching the filesystem to check the existence of the selected 
> filename, which is fine if its a fast local SSD, but not so much for a remote 
> SSHFS directory.

I'm not sure if that's a concern with a one-time command.  The loop may run up 
to 99 but it would never always go that far.  `g_file_test()` is also pretty 
much commonly used around Geany.

An option to disable this can be added if that's really a concern.

> 2) AFAICT it also changes the readonly behaviour, please do not include extra 
> things in an implementation not described in the PR.

Ok, reverted.

> 3) probably needs user documentation :)

Done.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1191#issuecomment-242067864

Reply via email to