b4n commented on this pull request.

Mostly LGBI

> @@ -47,6 +47,7 @@ typedef enum
        GCB_PROJECT_OPEN,
        GCB_PROJECT_SAVE,
        GCB_PROJECT_CLOSE,
+       GDB_PROJECT_BEFORE_CLOSE,

Yeah, and this enum isn't in the API either.

> @@ -156,6 +156,12 @@ static void create_signals(GObjectClass *g_object_class)
                G_SIGNAL_RUN_FIRST,
                0, NULL, NULL, g_cclosure_marshal_VOID__VOID,
                G_TYPE_NONE, 0);
+       geany_object_signals[GDB_PROJECT_BEFORE_CLOSE] = g_signal_new (
+               "project-before-close",
+               G_OBJECT_CLASS_TYPE (g_object_class),
+               G_SIGNAL_RUN_FIRST,
+               0, NULL, NULL, g_cclosure_marshal_VOID__VOID,
+               G_TYPE_NONE, 0);

Wouldn't it be better if the signal received the `GeanyProject` as argument?
OK, it'd be inconsistent with the other project signals, so maybe it's a bad 
idea. Or maybe it's a good idea to break one less thing in the future if we 
want to allow more than one project to be open?  That might not make much sense 
because the other signals would have to be changed anyway, so meh.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1223#pullrequestreview-469872

Reply via email to