b4n commented on this pull request.


>               main_quit();
        }
+       return G_SOURCE_REMOVE;

I guess it depends on whether or not returning `CONTINUE` will remove the 
signal handler altogether and restore the default action or not.

Because IMO
* it makes more sense to return `CONTINUE`, unless we *mean* not to handle the 
signal anymore
* it is often customary to stop handling these kind of signals after receiving 
them for the first time, so that if the app still doesn't quit sending it again 
will just terminate it, just not necessarily cleanly.  So that might suggest 
`REMOVE`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1255

Reply via email to