b4n requested changes on this pull request.

LGTM apart the small typo and the merge conflict.

> @@ -156,6 +156,12 @@ static void create_signals(GObjectClass *g_object_class)
                G_SIGNAL_RUN_FIRST,
                0, NULL, NULL, g_cclosure_marshal_VOID__VOID,
                G_TYPE_NONE, 0);
+       geany_object_signals[GDB_PROJECT_BEFORE_CLOSE] = g_signal_new (

typo: prefix should be `GCB_`, not `GDB_`

> @@ -47,6 +47,7 @@ typedef enum
        GCB_PROJECT_OPEN,
        GCB_PROJECT_SAVE,
        GCB_PROJECT_CLOSE,
+       GDB_PROJECT_BEFORE_CLOSE,

Ditto

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1223#pullrequestreview-5366433

Reply via email to