b4n commented on this pull request.


> @@ -2289,6 +2290,32 @@ static gint get_fold_header_after(ScintillaObject 
> *sci, gint line)
 }
 
 
+/* returns the line after following all brace match for @brace on @line */
+static gint resolve_matching_braces(ScintillaObject *sci, gint line, gint 
brace)
+{
+       gint pos = sci_get_position_from_line(sci, line);
+       gint line_end = sci_get_line_end_position(sci, line);
+       gint lexer = sci_get_lexer(sci);

> Looks OK to me, what's hard to read about it?

I find this overlong precondition hides the logic of the loop (condition and 
post-body).

Anyway, the new code is different, do you still think I should so something 
like that now the 2 other variables are constant?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1280

Reply via email to