> Hum, if the new proposed API is case-sensitive and the previous wasn't, it 
> could be a problem if it's not clear enough in the docs.

I don't think so since it should do what is expected for filenames (see below).

> Also, how does it affect Windows? (where filesystem names are case 
> insensitive I believe)

It basically fixes non-Windows and "breaks" Windows. In one of the intermediate 
commits on this branch where I added support for the dot but before using 
pattern matching, I had accounting for this by adding a conditional code to do 
proper UTF-8 windows case insensitive comparison, but it doesn't apply this 
this.

One way to support it would be to casefold all of the extensions and casefold 
the filename and then compare them in a `#if` for Windows.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1236#issuecomment-257092216

Reply via email to