b4n commented on this pull request.
LGBI but maybe too debug-verbose?
> + GError *error = NULL;
+ GeanyDocument *doc = document_get_current();
+
+ /* If the current document has a known path (ie. is saved), use that,
+ * substituting the file's basename for `index.html`. */
+ if (DOC_VALID(doc) && doc->real_path != NULL) {
+ gchar *base_dir = g_path_get_dirname(doc->real_path);
+ base_path = g_build_filename(base_dir, "index.html", NULL);
+ g_free(base_dir);
+ }
+ /* Otherwise assume use a file `index.html` in the current working
directory. */
+ else {
+ gchar *cwd = g_get_current_dir();
+ base_path = g_build_filename(cwd, "index.html", NULL);
+ g_free(cwd);
+ g_debug("current document is not saved, using '%s' as base filename",
base_path);
might be too spammy if this function is called often (e.g when typing?)
> + g_free(base_dir);
+ }
+ /* Otherwise assume use a file `index.html` in the current working
directory. */
+ else {
+ gchar *cwd = g_get_current_dir();
+ base_path = g_build_filename(cwd, "index.html", NULL);
+ g_free(cwd);
+ g_debug("current document is not saved, using '%s' as base filename",
base_path);
+ }
+
+ base_uri = g_filename_to_uri(base_path, NULL, &error);
+ if (base_uri == NULL) {
+ g_warning("failed to encode path '%s' as URI: %s", base_path,
error->message);
+ g_error_free(error);
+ base_uri = g_strdup("file://./index.html");
+ g_debug("using phony base URI '%s', broken relative paths are likely",
base_uri);
Same here if it's expected to happen in real situation (?)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/501#pullrequestreview-8265559
