b4n commented on this pull request.


> @@ -826,14 +988,27 @@ static gchar *prepare_run_cmd(GeanyDocument *doc, gchar 
> **working_dir, guint cmd
        }
 #endif
 
-       run_cmd = build_create_shellscript(*working_dir, cmd_string, autoclose, 
&error);
-       if (!run_cmd)
-       {
-               ui_set_statusbar(TRUE, _("Failed to execute \"%s\" 
(start-script could not be created: %s)"),
-                       !EMPTY(cmd_string_utf8) ? cmd_string_utf8 : NULL, 
error->message);
-               g_error_free(error);
-               g_free(*working_dir);
-       }
+#ifdef G_OS_WIN32
+       /* Expand environment variables like %blah%. */
+       SETPTR(cmd_string, win32_expand_environment_variables(cmd_string));
+#endif
+
+       gchar *helper = 
g_build_filename(utils_resource_dir(RESOURCE_DIR_LIBEXEC), "geany-run-helper", 
NULL);

Yes, but I think it should be added after (e.g. is slightly out of scope here)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1300

Reply via email to