We generally like to ask PR authors to do it for two reasons, one good, and one bad: * The good reason is that, if there are many commits and not everything should be squashed together but only some fixes to specific commits, the author is more likely to easily know what fix should got to what commit. * The bad reason is that GitHub doesn't provide a way to mark PRs as merged if squashing manually (e.g. not using their squash button) and not pushed to the PR branch. Best we can do is close them.
However, we are aware that not everybody is comfortable enough with Git to squash manually without fear or trial and error, so ultimately we are happy to do it for anyone not comfortable doing it him/herself. Also, last thing: we always prefer squashing to happen at the very end of a PR review process, when everything is sorted out. Squashing commits during review iterations makes it harder to see changes for reviewers, so apart for really simple commits it's better to wait for approval. You've got mine for this one so it's fine though :) So, **the summary is**: if you have no problem doing it, please, do. Otherwise, don't worry for a second and we'll do it ourselves. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1323#issuecomment-263067509
