kugel- commented on this pull request.
>
> -DGEANYPY_PYTHON_DIR="\"$(libdir)/geany/geanypy\"" \
-DGEANYPY_PLUGIN_DIR="\"$(libdir)/geany\"" \
-DG_LOG_DOMAIN=\"GeanyPy\"
-geanypy_la_CFLAGS = @GEANYPY_CFLAGS@
@GMODULE_CFLAGS@
+geanypy_la_CFLAGS = @PYGTK_CFLAGS@ @GEANY_CFLAGS@
@GEANYPY_CFLAGS@ @GMODULE_CFLAGS@
I think the previous code is better. *_CFLAGS derived from PKG_CONFIG_CHECK()
contain include paths (and usually nothing else) so they should be added to
automake's *_CPPFLAGS indeed.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/527#pullrequestreview-22431721
